Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release artifact upload. #946

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix release artifact upload. #946

merged 1 commit into from
Dec 9, 2023

Conversation

basicer
Copy link
Contributor

@basicer basicer commented Nov 22, 2023

Fixes publishing build artifacts into the latest release and also builds and includes the fallback wasm build.

@basicer
Copy link
Contributor Author

basicer commented Nov 23, 2023

Also something is going on with the nasm tests on CI where they pass if they use the cache but fail for clean builds.

@copy
Copy link
Owner

copy commented Nov 26, 2023

Thanks! I'm a bit busy right now, will look at this again in two weeks.

@copy
Copy link
Owner

copy commented Dec 3, 2023

Also something is going on with the nasm tests on CI where they pass if they use the cache but fail for clean builds.

If you rebase on master this should be fixed, and then good to merge.

@copy copy merged commit fe7a0fb into copy:master Dec 9, 2023
3 checks passed
@copy
Copy link
Owner

copy commented Dec 9, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basicer @copy