Remove spurious ControlLeft-key when AltRight is pressed under Windows #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ControlLeft from keyboard input sequence ControlLeft + AltRight if platform is Windows and AltRight is pressed.
chschnell
changed the title
Replaced logical expression for better clairty.
copy
reviewed
Sep 3, 2024
src/browser/keyboard.js
Outdated
| deferred_timeout_id = setTimeout(() => { | ||
| send_to_controller(deferred_code); | ||
| deferred_code = 0; | ||
| }, 10); |
There was a problem hiding this comment.
I think this logic should be moved earlier in the chain, into handler before translate. That way we don't have to pass through the event object, keys_pressed doesn't get infected, and we can use e.code === "AltLeft" directly.
There was a problem hiding this comment.
I changed it, much less intrusive now. I made sure that the remaining parts of the call chain are all reverted back to their current form in master.
Moved filter mechanics into function handler(). Split handler() into two function, the upper half up until translate() remained in handler(), the rest moved into new function handle_event(). Changed from scancode-based key detection to KeyboardEvent.code. Made the global const WINDOWS_PLATFORM uppercase.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ControlLeft from keyboard input sequence
ControlLeft + AltRightif platform is Windows andAltRightis pressed.See issue #1127 for more details.