Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): Upgrade to Copilot 1.40.0 #338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

knilink
Copy link

@knilink knilink commented Sep 7, 2024

update lsp to 1.40

  • added initialized notification which required by later lsp server
  • updated script entry from agent.js to language-server.js, assuming not supporting backward compatible since copilot.el enforcing copilot-node-server's version

i am not subscribing copilot and only tested with modded lsp server based on copilot.vim so may need someone else help testing it

P.S.
proposed copilot-node-server to add executable entry point jfcherng/copilot-node-server#17
so start from next release the server should be easily started by npx -y copilot-node-server@1.40.0 --stdio therefor can consider simplify the installation and version management later

@alexmurray
Copy link
Contributor

FWIW (I am not part of the copilot-emacs project but just an avid user), the upstream copilot.vim project renamed the agent.js file to language-server.js in the 1.34.0 release, so you will also need to update the references to this as well in copilot--server-executable - but otherwise I tested this briefly and it works for me! Thanks.

alexmurray added a commit to alexmurray/dot_emacs.d that referenced this pull request Sep 11, 2024
Requires a minor update to copilot.el from
copilot-emacs/copilot.el#338 which I have applied
locally until this is merged.

Signed-off-by: Alex Murray <murray.alex@gmail.com>
@jfcherng
Copy link

jfcherng commented Sep 12, 2024

the upstream copilot.vim project renamed the agent.js file to language-server.js in the 1.34.0 release

Yes, this kind of issue can be avoided by @knilink's proposal. It can be directly dealt at https://github.com/jfcherng/copilot-node-server/blob/a4a18ba57b6a21c416c60b6037e46c177529ac10/package.json#L6 if the user uses npx to start the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants