Test nested include paths: paths are relative to copier.yml
#2262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scluded files Also add the demo files for the test in `tests/demo_nested_transcludes`. When nested transcluded files are populated, the transclusion will result in a failure of the type: ```bash E yaml.composer.ComposerError: expected a single document in the stream E in "<byte string>", line 2, column 1: E !include ../copier_files/nested/ ... E ^ E but found another document E in "<byte string>", line 3, column 1: E --- E ^ ```
Changed from `demo_nested_trancludes` to `demo_transclude_nested`
Per review request. Note that if it is decided that pure path relativity is better, one just has to reverse the tests. Refs: copier-org#2251#pullrequestreview-3076712643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Check the current behaviour of copier.
Add a test to check that "nested include paths are all relative to
copier.yml", and its converse test to check that includes relative to each other and not tocopier.yamldoes not work.(Was proposed as a result of: Refs: #2251#pullrequestreview-3076712643)
Possible future change
In the case, it is decided, in the future, that the converse makes more sense, and thus, becomes the desideratum, moving the
notfrom one test to the other would be enough to validate the converse and invalidate the current.