-
-
Notifications
You must be signed in to change notification settings - Fork 30
Android push notifications with PassWallet #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mandyJ
wants to merge
12
commits into
coorasse:main
Choose a base branch
from
omahazoo:android_push_notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
30b0f4a
new endpoint
c48b59b
add route
737e740
do pre load
1e7d70d
adding push url column
de5e80e
fix migraton naming
0cc46ee
fix migraton naming
be22182
store push service url
c6f6e71
logging
8f98813
store push service url
e9a017a
store push service url
5e0e9b4
use same create method
812d383
remove unneeded code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,7 +73,9 @@ def load_device | |
| end | ||
|
|
||
| def register_device | ||
| device = Passkit::Device.find_or_create_by!(identifier: params[:device_id]) { |d| d.push_token = push_token } | ||
| device = Passkit::Device.find_or_create_by!(identifier: params[:device_id]) | ||
| device.update(push_token: push_token, push_service_url: push_service_url) | ||
|
|
||
| @pass.registrations.create!(device: device) | ||
| end | ||
|
|
||
|
|
@@ -105,6 +107,14 @@ def push_token | |
| json_body = JSON.parse(request.body.read) | ||
| json_body["pushToken"] | ||
| end | ||
|
|
||
| def push_service_url | ||
| return unless request&.body | ||
|
|
||
| request.body.rewind | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks fairly atypical. Can you not acccess it with |
||
| json_body = JSON.parse(request.body.read) | ||
| json_body["pushServiceUrl"] | ||
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
lib/generators/templates/add_push_service_url_to_devices.rb.tt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| class AddPushServiceUrlToDevices < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>] | ||
| def change | ||
| add_column :passkit_devices, :push_service_url, :string | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the previous version, no changes are made to the db a device is found. Now, the device is being updated every time.
Maybe like this to back fill missing push_service_url?