Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][ADD] hr_timesheet_overtime_rate_holidays #42

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[12.0][ADD] hr_timesheet_overtime_rate_holidays #42

merged 2 commits into from
Oct 11, 2024

Conversation

carmenbianca
Copy link
Member

Description

Backported from #34

Odoo task (if applicable)

T12628

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

huguesdk
huguesdk approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! only the auto-install should be changed. the rest of my (pedantic ☺️) review will be done on the 16.0 version (#34).

hr_timesheet_overtime_rate_holidays/__manifest__.py Outdated Show resolved Hide resolved
@carmenbianca
[ADD] hr_timesheet_overtime_rate_holidays
bef21de 
I really dislike writing Odoo tests. They take so so so so long to
write, building a global state like a house of cards.

Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
[MIG] hr_timesheet_overtime_rate_holidays: Migrate to 12.0
94fd511 
Signed-off-by: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@huguesdk
Copy link
Member

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-42-by-huguesdk-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit 313ed59 into 12.0 Oct 11, 2024
2 checks passed
@github-grap-bot github-grap-bot deleted the 12.0-mig-holidays branch October 11, 2024 09:31
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 59316fd. Thanks a lot for contributing to coopiteasy. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesdk huguesdk huguesdk approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carmenbianca @huguesdk @github-grap-bot