-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] Store computed values working_time and timesheet_overtime #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
12.0-store-fields-overtime
branch
from
June 3, 2022 14:24
644b78b
to
ee49562
Compare
Codecov Report
@@ Coverage Diff @@
## 12.0-provelo-custom #20 +/- ##
========================================================
- Coverage 91.87% 53.82% -38.05%
========================================================
Files 22 22
Lines 357 431 +74
Branches 45 52 +7
========================================================
- Hits 328 232 -96
- Misses 23 193 +170
Partials 6 6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
3 tasks
carmenbianca
changed the title
12.0 store fields overtime
[12.0] Store computed values working_time and timesheet_overtime
Jun 3, 2022
huguesdk
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. 🎉 great job! thanks carmen!
carmenbianca
commented
Jun 4, 2022
carmenbianca
force-pushed
the
12.0-store-fields-overtime
branch
from
June 16, 2022 12:25
2acfb20
to
85cb2da
Compare
carmenbianca
force-pushed
the
12.0-provelo-custom
branch
from
June 16, 2022 12:28
862a4bf
to
defc784
Compare
carmenbianca
force-pushed
the
12.0-store-fields-overtime
branch
from
June 16, 2022 12:46
85cb2da
to
675fd86
Compare
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
12.0-store-fields-overtime
branch
from
June 16, 2022 12:49
675fd86
to
acc1144
Compare
…et_overtime This is technically not very useful; these values will be recomputed every time a new thing is timesheeted. However, it allows you to aggregate all working hours and overtime hours when using 'group by' in the timesheet tree view. This change is extensively tested. Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
carmenbianca
force-pushed
the
12.0-store-fields-overtime
branch
from
June 16, 2022 12:50
acc1144
to
070e906
Compare
Signed-off-by: Carmen Bianca Bakker <carmen@coopiteasy.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change overtime into stored fields.
Depends on coopiteasy/addons#243
Builds on top of #16
Odoo task (if applicable)
https://gestion.coopiteasy.be/web#id=4362&action=475&active_id=198&model=project.task&view_type=form&menu_id=536
Checklist before approval