-
Notifications
You must be signed in to change notification settings - Fork 69
Inter-organizational Contact and Time Transfers #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmartincor
wants to merge
17
commits into
interbank-offer-visibility
Choose a base branch
from
interorg-user-contact
base: interbank-offer-visibility
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+809
−241
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a35ceab
Transfer time Between diferents organizations
gmartincor 5897a3c
correct logic model and view
gmartincor 6a0ab38
correct style
gmartincor 4721f1c
deliver_later
gmartincor ad285fc
tests
gmartincor 58333b6
Correct offers visibility
gmartincor a45b9ea
Correc test offers Visibility
gmartincor 4db2fb6
Add cross-bank transfer validation to only allow transfers between al…
gmartincor 4da8396
Update cross-bank transfer tests to include alliance creation
gmartincor 4e02352
Change default posts visibility to only show current organization's p…
gmartincor d187452
Update tests to reflect new organization filtering behavior
gmartincor 409b3e3
Fix tests for organization behavior change
gmartincor 912c39a
refactor code
gmartincor 8dcb5ae
fix tests
gmartincor de613b3
refactor code
gmartincor 5850505
refactor code
gmartincor 494d11d
structure.sql
gmartincor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
59 changes: 27 additions & 32 deletions
59
app/assets/javascripts/application/organizations_filter.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,33 +1,28 @@ | ||
// app/assets/javascripts/application/organization_filter.js | ||
$(function() { | ||
// Manejar cambios en las casillas de organizaciones | ||
$(document).on('change', '.organization-checkbox', function() { | ||
// Obtener valores actuales de la URL | ||
var searchParams = new URLSearchParams(window.location.search); | ||
var cat = searchParams.get('cat'); | ||
var q = searchParams.get('q'); | ||
var tag = searchParams.get('tag'); | ||
|
||
var form = $(this).closest('form'); | ||
|
||
// Mantener parámetros actuales | ||
if (cat) { | ||
if (form.find('input[name="cat"]').length === 0) { | ||
form.append('<input type="hidden" name="cat" value="' + cat + '">'); | ||
} | ||
} | ||
|
||
if (q) { | ||
form.find('input[name="q"]').val(q); | ||
} | ||
|
||
if (tag) { | ||
if (form.find('input[name="tag"]').length === 0) { | ||
form.append('<input type="hidden" name="tag" value="' + tag + '">'); | ||
} | ||
} | ||
|
||
// Enviar el formulario | ||
form.submit(); | ||
}); | ||
}); | ||
$(document).on('change', '.organization-checkbox', function() { | ||
var searchParams = new URLSearchParams(window.location.search); | ||
var cat = searchParams.get('cat'); | ||
var q = searchParams.get('q'); | ||
var tag = searchParams.get('tag'); | ||
|
||
var form = $(this).closest('form'); | ||
|
||
if (cat) { | ||
if (form.find('input[name="cat"]').length === 0) { | ||
form.append('<input type="hidden" name="cat" value="' + cat + '">'); | ||
} | ||
} | ||
|
||
if (q) { | ||
form.find('input[name="q"]').val(q); | ||
} | ||
|
||
if (tag) { | ||
if (form.find('input[name="tag"]').length === 0) { | ||
form.append('<input type="hidden" name="tag" value="' + tag + '">'); | ||
} | ||
} | ||
|
||
form.submit(); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Relying on a string comparison for the 'cross_bank' parameter could be error-prone if the parameter type changes. Consider normalizing the parameter to a boolean value before performing the comparison.
Copilot uses AI. Check for mistakes.