-
Notifications
You must be signed in to change notification settings - Fork 69
TravisCI -> GH Actions #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
38fb9ae
to
f36138c
Compare
@sauloperez Did you see any similar error in the past? I basically copy-pasted from OFN, but apparently Rails can't connect to |
e48ad8b
to
bc850cc
Compare
We can try with some more |
92ce258
to
3eca24a
Compare
@sauloperez changing those 2 things (ENV var naming and the
|
Oops, no. You are right, those ENV vars are defined by the PostgreSQL image. Nothing to do with the |
f50b516
to
51925dd
Compare
UPDATE I returned back to check an extra ENV var (I'd like to avoid infra changes/coordination) and tried a couple of tweaks more (more retries and newer PostgreSQL versions), but still no luck :(
|
UPDATE After some random back and forth, I made some progress. Now the PostgreSQL service seems to start well, but it still fails due to:
@sauloperez do you have any idea about this one? |
yes, that is using the |
UPDATE I tried forcing the hstore installation (7d11937), but no luck :( Line 28 in 85dd90f
@sauloperez Do you think we need something else to get the |
Yay! 🎉 Build is green now! Never give up 💪🏼 |
@franpb14 What do you think? Could you please review it and test it locally 🙏🏼? The most "critical" thing is the migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is working fine after the migrate. Tests & server working 🎉 🥳
Closes #646
NOTES
host
andpassword
DB settings.collation
andctype
doesn't work on CI, I kept them for current staging/pro infra.hstore
column (for categories translations) should be migrated tojsonb
(as we are relying on https://github.com/cfabianski/json_translate). In the future (after this PR reaches production) we can remove this extension. This fixes the error: