-
Notifications
You must be signed in to change notification settings - Fork 69
feat: tags and postal code attributes #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
postcode was added to users and tags to members. For the postcode was added to users and tags to members. For the postcode I used the rails form but for the tags I used Html. Issue #623.
😍 Just to be sure @franpb14 tags are shared only on the same organization? This is how it works in Posts |
Yes, tags is an attribute of the member model. So, for example, a user can have "tag1 and tag2" in one organisation and "otherTag and ultimaTag" in another. And if you want to see the tags of an organisation, just take the members of the organisation and extract the tags. |
The problem was solved by indicating the table where to search for the tag in the query that was failing. Here is the commit that solves it. |
hi @franpb14 👋🏼 I think we can use this same branch and PR to add the other two points. The searcher and the autocomplete, seem quite "small" tasks (we have examples of both in current code base) and very tied to this code. PS comment for latest commit 32f4ebe: this is a concern (a mixin with steroids) to be injected in other classes, so hardcoding the a table name seems wrong to me, it should use the table of the injected AR class, we can do it by using the |
All steps in #623 are complete. I have two videos, the first one is related to the searchers working on tags: Issue_623_searcher.mp4And the last video is related to tag autocompletion taking into account the members tags and how to show the tags in "/tags/alpha_grouped_index": Issue_623_autocomplete.mp4 |
OMG I love this feature, also I like really much that you added it on tags list page 👏 👏 👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello @franpb14 very nice improvements 👏🏼 👏🏼 I just completed the review and added some comments. Let me know what do you think?
Thank you very much @markets :). All changes are fine, I will make them between today and tomorrow. |
And I have also added @member in case of failure of the forms.
@markets all the feedback is incorporated and I have also added member in case of failure of the forms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franpb14 @sseerrggii ready for staging! ✅ (i18n keys already added in Localeapp and pulled here)
Tested manually ✔️ |
Postal code is related to users and tags is related to members (for those who belong to more than one organisation, they can have different tags depending on the organisation).
Closes #623
Issue623.mp4