Skip to content

keep org filter (scope) in public search #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2021
Merged

keep org filter (scope) in public search #592

merged 3 commits into from
Feb 22, 2021

Conversation

markets
Copy link
Collaborator

@markets markets commented Feb 21, 2021 •
edited
Loading

Closes #508

Ideally, we should implement the "scope everything" project, we all agree... but that will take time, meanwhile this is probably worth it.

Extras

  • updated rails ⬆️ , patch version (I reviewed the diff and the changelogs, it's safe to upgrade)
  • refactored Reports CSV/PDF code, much more DRY 👌🏼 (I tested this and works fine, but @sseerrggii will take a second look 🙏🏼 please)

@sseerrggii
Copy link
Contributor

Tested! ✔️

  • Searching loggedout with and without org
  • Export reports to CSV & PDF

Thanks @markets 👏

@sseerrggii sseerrggii merged commit 88d7262 into develop Feb 22, 2021
@markets markets deleted the keep_org_in_public_search branch February 22, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

organization filter is lost when filtering
2 participants
@markets @sseerrggii