-
Notifications
You must be signed in to change notification settings - Fork 69
Remove deprecated attributes in posts table (closes #471) #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😍 👏
@markets would you mind to remove them? Do you need some help for that from @sseerrggii ? |
I can delete keys from repo manually, but I think we should remove them in Locale app first, so the next pull via the gem will delete them automatically. @sseerrggii how we usually manage keys removal? Is that process ok? |
If you delete keys in en.yml you must delete it in localeapp with:
https://github.com/coopdevs/timeoverflow/wiki/Translations-Localeapp-i18n#warning-warning |
@sseerrggii I just deleted the keys from the repo (2970e64) but I don't have an |
👍 No problem @markets The keys |
@@ -0,0 +1,5 @@ | |||
class RemoveUserJoinedPostTable < ActiveRecord::Migration | |||
def change | |||
drop_table :user_joined_post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In production
this table contains just one record, I would say it was just a test.
@sseerrggii would you mind to deploy this PR in |
✔️ CRUD of Post tested in staging 👍 |
Closes #471
Yep, those attributes are unused by the application 🔥
In addition, these 2 i18n keys can be also deleted:
EXTRA EXTRA remove also an unused table: 3506af3