Skip to content

Remove deprecated attributes in posts table (closes #471) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

markets
Copy link
Collaborator

@markets markets commented Apr 11, 2019

Closes #471

Yep, those attributes are unused by the application 🔥

In addition, these 2 i18n keys can be also deleted:

  • activerecord.attributes.post.joinable
  • activerecord.attributes.post.permanent

EXTRA EXTRA remove also an unused table: 3506af3

@Morantron
Copy link
Collaborator

@enricostano
Copy link
Contributor

😍 👏

In addition, these 2 i18n keys can be also deleted:

activerecord.attributes.post.joinable
activerecord.attributes.post.permanent

@markets would you mind to remove them? Do you need some help for that from @sseerrggii ?

@markets
Copy link
Collaborator Author

markets commented Apr 14, 2019

I can delete keys from repo manually, but I think we should remove them in Locale app first, so the next pull via the gem will delete them automatically. @sseerrggii how we usually manage keys removal? Is that process ok?

@sseerrggii
Copy link
Contributor

sseerrggii commented Apr 15, 2019

If you delete keys in en.yml you must delete it in localeapp with:

bundle exec localeapp rm <key>

https://github.com/coopdevs/timeoverflow/wiki/Translations-Localeapp-i18n#warning-warning

@markets
Copy link
Collaborator Author

markets commented Apr 15, 2019

@sseerrggii I just deleted the keys from the repo (2970e64) but I don't have an API KEY to use the Localeapp API for this project, maybe you can delete them for me 🙏 ?

@sseerrggii
Copy link
Contributor

sseerrggii commented Apr 16, 2019

👍 No problem @markets

The keys joinable & permanent were removed from en.yml in localeapp

@@ -0,0 +1,5 @@
class RemoveUserJoinedPostTable < ActiveRecord::Migration
def change
drop_table :user_joined_post
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In production this table contains just one record, I would say it was just a test.

@enricostano
Copy link
Contributor

@sseerrggii would you mind to deploy this PR in staging and test that you can create posts? Thanks.

@sseerrggii
Copy link
Contributor

✔️

CRUD of Post tested in staging 👍

@enricostano enricostano merged commit 5093f0c into develop Apr 16, 2019
@enricostano enricostano deleted the clean_posts_table branch April 16, 2019 15:24
@sseerrggii sseerrggii mentioned this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused ( maybe? ) columns in posts table
4 participants