Update ruby 2.3.0 -> 2.5.3

[viktorsmari]

If you first merge #443 , then this test should pass (if you force rerun it)

[enricostano]

@viktorsmari #443 has been merged, thanks for your time!

[markets]

Hi @viktorsmari and thanks a lot for contributing! 👍

I just restarted the build via the Travis UI, but it failed again. I still see Ruby 2.3.0 ("rvm": "2.3.0") here: https://travis-ci.org/coopdevs/timeoverflow/jobs/443203668/config ...

¯_(ツ)_/¯ maybe a caching issue?

[viktorsmari]

Of course, Travis only builds this PR, and the other PR #443 I made, even though it is already merged to develop, does not automatically 'join' this one.
I was afraid to 'break' this PR so I made another one just for testing #445
Do you know how can should correctly merge/rebase current develop branch into this PR?
Should I just do a git merge develop or git rebase develop and push it?

[markets]

does not automatically 'join' this one

ouch! yes of course 😅 I do not know why, I thought it was already rebased 🙏

About merge vs rebase. I prefer rebase when I'm working alone in a branch, but merge when working on a shared branching project/feature. Also, now that we have an squash button in GitHub, I sometimes squash all commits before merging directly via the UI... So no problem, both are fine, we do not have a policy on this subject either :)

Thanks!

[viktorsmari]

I actually thought the same, that Travis would somehow know develop had changed!
But I pushed the rebased changes and Travis is building!

[enricostano]

Hi @viktorsmari I still see some commit from others PRs, could you please check again? Thanks!

[viktorsmari]

Hi @enricostano I just did what @markets asked me to do, to rebase this PR.
Can you tell me the correct way to do this? 🙉
I also did another copy of this PR, check #445 - maybe it is cleaner?

[enricostano]

@viktorsmari did you sync your fork with latest changes upstream?

https://help.github.com/articles/syncing-a-fork/

Once you have the latest develop branch in your fork, go to this PR's branch and run git rebase develop. A forced push will be needed. I hope this will help you.

Many thanks for your time!

[viktorsmari]

Thanks for your patience @enricostano 😄
It was the --force push that was missing, I am always afraid of using it 😆
I noticed they released a security update 2.3.8, 2 days ago, I am including it now, is that okay?

[enricostano]

Perfect, thanks!

[enricostano]

Many thanks for your work on this @viktorsmari , I just want to inform you that this specific PR will be merged in a while. We're having some issues upgrading Ruby on the production machine and we're also planning to change the server in order to upgrade Ruby and more things.

So, don't worry if you see this PR not merged during some time, we still cannot say how long it will take. Sorry for the wait but keep the PRs coming! 😂 💪

[viktorsmari]

What are we using in production? rvm or rbenv or other?
I have personally used rbenv in production with great results.
But recently at work I have moved to docker-compose for websites like https://fablabs.io and https://api.smartcitizen.me

I have just been testing newer ruby versions like 2.5.3 and all rake tests pass on that! So I could make another PR for newer versions.

[enricostano]

Right now in production we're using an old server that uses a packaged version of Ruby, we don't like it and we will switch to rbenv. That's why in timeoverflow-provisioning repo the stage production is still missing.

As soon as we have more resources we'll be able to move forward with this plan at system administration level. I hope before the end of 2018, but it depends on many things.

[markets]

Hi @viktorsmari @enricostano, since we're going to take a while, I agree we'd upgrade to latest stable release 2.5.3 👌 I tested locally this version and everything seems to work fine.

[enricostano]

This PR has been superseded by #502

We're slooooowly moving forward updating our dependencies. I'm sorry this PR could not be merged before 😞