-
Notifications
You must be signed in to change notification settings - Fork 69
Little improvements in /members #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mllocs
commented
Sep 25, 2018
- Do not hide actions in the manage users page
- Sort members by last_sign_in_at
- Truncate member description
- Hide telephone icon when there is no phone number
<span class="glyphicon glyphicon-earphone"></span> | ||
<%= phone_to member.phone %> | ||
</div> | ||
<% if member.phone && !member.phone.blank? %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if member.phone.present?
should be enough, wdyt?
Deployed to https://staging.timeoverflow.org cc/ @sseerrggii |
Hi, some things to improve:
|
@@ -40,12 +40,16 @@ | |||
describe "GET #index" do | |||
before { login(user) } | |||
|
|||
it 'sorts the users by their member_uid asc by default' do | |||
it 'sorts the users by their user_last_sign_in_at desc by default' do | |||
member.increment!(:member_uid, Member.maximum(:member_uid) + 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can ✂️ this line, it seems unnecessary now that we use a different attribute by default
c940928
to
ecbb5ed
Compare
@markets thanks for the tips! |
df667a8
to
9208d17
Compare
🍏 |