Skip to content

Little improvements in /members #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 19, 2018
Merged

Conversation

mllocs
Copy link
Collaborator

@mllocs mllocs commented Sep 25, 2018

  • Do not hide actions in the manage users page
  • Sort members by last_sign_in_at
  • Truncate member description
  • Hide telephone icon when there is no phone number

@mllocs
Copy link
Collaborator Author

mllocs commented Sep 25, 2018

@mllocs
Copy link
Collaborator Author

mllocs commented Sep 25, 2018

@mllocs
Copy link
Collaborator Author

mllocs commented Sep 25, 2018

@mllocs
Copy link
Collaborator Author

mllocs commented Sep 25, 2018

<span class="glyphicon glyphicon-earphone"></span>
<%= phone_to member.phone %>
</div>
<% if member.phone && !member.phone.blank? %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if member.phone.present? should be enough, wdyt?

@enricostano
Copy link
Contributor

Deployed to https://staging.timeoverflow.org

cc/ @sseerrggii

@sseerrggii
Copy link
Contributor

Hi, some things to improve:

  • the order of members don't work, maybe is because user_last_sign_in_at belongs to user?
  • Also we want to show the activity date insted of Active Ago like "Active 2 weeks Ago" isn't it
    fireshot capture 72 - banco de tiempo local - https___staging timeoverflow org_members
  • Also we have some email field empty (internally whatever@example.com) in this case we don't want to show email icon:
    fireshot capture 73 - banco de tiempo local - https___staging timeoverflow org_members

@@ -40,12 +40,16 @@
describe "GET #index" do
before { login(user) }

it 'sorts the users by their member_uid asc by default' do
it 'sorts the users by their user_last_sign_in_at desc by default' do
member.increment!(:member_uid, Member.maximum(:member_uid) + 1)
Copy link
Collaborator

@markets markets Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can ✂️ this line, it seems unnecessary now that we use a different attribute by default

@markets
Copy link
Collaborator

markets commented Oct 16, 2018

Closes #426
Closes #425
Closes #439

@markets
Copy link
Collaborator

markets commented Oct 18, 2018

Hi @mllocs 👋 we merged #416, where I made some changes to these partials:

  • _user_rows.html.erb => _user_row.html.erb
  • _member_card.html.erb just wrapped code into <div class="col-lg-6 col-sm-12">

Hope it helps with merge conflicts 😺 🙏

@mllocs mllocs force-pushed the fix/members-small-issues branch from c940928 to ecbb5ed Compare October 19, 2018 13:41
@mllocs
Copy link
Collaborator Author

mllocs commented Oct 19, 2018

@markets thanks for the tips!
@sseerrggii rebased and fixed the issues you mentioned :)

@mllocs mllocs force-pushed the fix/members-small-issues branch from df667a8 to 9208d17 Compare October 19, 2018 15:27
@sseerrggii
Copy link
Contributor

🍏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants