Improved main views on mobile devices #375
Conversation
mllocs
commented
Jun 3, 2018
mllocs
commented
- Improved the main views on small devices.
- Added a filter on the cover image to look better with the new brand blue.
- Used bootstrap's Grid system to improve responsiveness and fix inconsistent paddings.
|
Deployed on https://staging.timeoverflow.org/ @mllocs could you please check that everything is OK? Thanks! |
| @@ -44,21 +44,19 @@ | |||
| <% if current_user && current_organization %> | |||
| <nav role="navigation"> | |||
| <div class="container-fluid"> | |||
There was a problem hiding this comment.
@mllocs I think this should be "container", with "container-fluid" looks weird on desktop:
| <div class="row"> | ||
| <div class="col-xs-12 col-sm-12 col-md-12 col-lg-12"> | ||
| <ul class="nav nav-pills actions-menu"> | ||
| <%= render 'application/menus/user_list_link' %> |
There was a problem hiding this comment.
Can we fix indentation here?
| @@ -418,7 +430,11 @@ form .checkbox input[type="checkbox"] { | |||
| } | |||
|
|
|||
| .navbar-static-top { | |||
| background-color: $palette-turkey; | |||
| background-color: rgba(39, 151, 175, 0.9); // @palette-turkey with opacity | |||
There was a problem hiding this comment.
can't this really be done in SCSS?
| @@ -567,6 +581,7 @@ form .checkbox input[type="checkbox"] { | |||
| font-weight: 500; | |||
| letter-spacing: -0.107rem; | |||
| margin-top: 1rem; | |||
| text-shadow: 1px 1px #333; | |||
There was a problem hiding this comment.
this deserves to be in a var IMO
|
We'll deploy this to staging again once @mllocs solves pending questions. |
|
@markets @enricostano @sauloperez Thanks guys! I just pushed come commits addressing your comments 😊 |
| @@ -418,7 +435,7 @@ form .checkbox input[type="checkbox"] { | |||
| } | |||
|
|
|||
| .navbar-static-top { | |||
| background-color: $palette-turkey; | |||
| background-color: rgba($palette-turkey, 0.9); | |||
There was a problem hiding this comment.
@sauloperez I didn't know this was possible :D
There was a problem hiding this comment.
I also flipé when I started doing CSS recently 😆
|
Deployed to https://staging.timeoverflow.org |
|
@enricostano Looks pretty good enough ™️ ®️ 🚢 🇮🇹 |
