Admin organizations order #361

markets · 2018-05-19T12:42:11Z

Closes #360

One annoying thing in Active Admin is when superadmin creates a new user and add membership the select of all organitzations list show the organitzations list without an order

Will be perfect if orgs are ordered by ID

EXTRA

Helpers cleanup:

remove empty helpers to avoid loading unnecessary constants (and it's pretty easy to add it again if necessary)
minor refactor on avatar_url helper
moved alert_class to ApplicationHelper (+ minor refactor)
use valid css error class when using show_error_messages!(resource) helper (possible regression introduce in d03726c)
added some tests for ApplicationHelper and GlyphHelper

enricostano · 2018-05-20T19:17:39Z

app/helpers/application_helper.rb

+      d: "identicon"
+    }
+
+    "https://www.gravatar.com/avatar/#{gravatar_id}.png?#{gravatar_options.to_param}"


I don't mean to do it now but these are the kind of things that I like to turn into a value object. And this will eventually reduce the amount of helpers. Just a thought worth sharing.

rewritten · 2018-05-21T16:24:12Z

Hey sorry to chime in now. Can we instead use RSpec.describe everywhere?

markets · 2018-05-21T21:59:14Z

Hi @rewritten, if I'm not wrong to use RSpec.describe is recommended by the RSpec team (https://relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/global-namespace-dsl) and the official docs, so I'm +1 to move to this form, but I'd leave it for a different PR, so the team can discuss about pros/cons, thoughts, settings, ....

rewritten · 2018-05-22T06:19:14Z

Works for me El El lun, 21 may 2018 a las 23:59, Marc Anguera Insa < notifications@github.com> escribió:

…

Hi @rewritten <https://github.com/rewritten>, if I'm not wrong to use RSpec.describe is recommended by the RSpec team ( https://relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/global-namespace-dsl) and the official docs, so I'm +1 to move to this form, but I'd leave it for a different PR, so the team can discuss about pros/cons, thoughts, settings, .... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#361 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdG3-xjdM5dCeTgm9K-glyIwkDjZlooks5t0ziygaJpZM4UFskx> .

enricostano · 2018-05-22T09:42:19Z

spec/spec_helper.rb

@@ -67,15 +68,12 @@
  # the seed, which is printed after each run.
  #     --seed 1234

-  puts "Randomized with seed #{config.seed}."
-


Is this printed out by default now? I find it useful.

Yes @enricostano, I saw it duplicated before:

After this:

Weirdly enough I don't see it duplicated in develop 🤔

@enricostano maybe you have a global .rspec with any kind of setting preventing this to be displayed?

Not that I am aware of 😂

timeoverflow@timeoverflow:/var/www/timeoverflow$ ls ~/.rspec ls: cannot access '/home/timeoverflow/.rspec': No such file or directory timeoverflow@timeoverflow:/var/www/timeoverflow$ ls ./.rspec ls: cannot access './.rspec': No such file or directory

Ok @enricostano, it's my global .rspec 😂

[2.3.0] markets: ~/workspace/timeoverflow (develop)$ more ~/.rspec --color --order random --format documentation

This is printed by default by RSpec if you have config.order = "random", but this was removed here: 94c50fb. I'm going to put it back 😅

enricostano · 2018-05-22T09:52:54Z

@markets @rewritten I created an issue to keep track of the RSpec scope thing #362

sauloperez · 2018-05-22T11:50:56Z

app/helpers/application_helper.rb

+      d: "identicon"
+    }
+
+    "https://www.gravatar.com/avatar/#{gravatar_id}.png?#{gravatar_options.to_param}"


I don't mean to do it now but these are the kind of things that I like to turn into a value object. And this will eventually reduce the amount of helpers. Just a thought worth sharing.

- remove empty helpers to avoid load unnecessary constants (can be added on demand easily) - add some tests for ApplicationHelper and GlyphHelper

…ec_helper.rb edits

- return to RSpec.describe as per #362 - manually print seed as we don't use "config.order = 'random'" (we're using a custom ordering) ~> more info. 94c50fb - [EXTRA] remove sudo in Travis

…ss class in show_error_messages! helper

markets · 2018-06-21T19:59:06Z

app/helpers/application_helper.rb

+    else
+      'alert-info'
+    end
+  end


@mllocs what do you think? specially this commit: 761c7ff 😄 I also fixed the css error class returned by show_error_messages!, now in develop looks like:

enricostano · 2018-08-08T11:07:44Z

Deployed on https://staging.timeoverflow.org/

enricostano · 2018-08-08T11:27:30Z

@sseerrggii tested it 🍏

markets mentioned this pull request May 19, 2018

Active admin: user to membership organitzations order #360

Closed

enricostano reviewed May 20, 2018

View reviewed changes

enricostano suggested changes May 22, 2018

View reviewed changes

enricostano mentioned this pull request May 22, 2018

Use RSpec scope and remove global namespace #362

Closed

sauloperez approved these changes May 22, 2018

View reviewed changes

enricostano approved these changes May 24, 2018

View reviewed changes

enricostano added the needs testing label May 24, 2018

markets changed the title ~~Admin orgs order~~ Admin organizations order Jun 13, 2018

markets mentioned this pull request Jun 20, 2018

Fixed "Remember me" in Login #380

Merged

markets added 5 commits June 21, 2018 21:33

Helpers cleanup:

b0c872e

- remove empty helpers to avoid load unnecessary constants (can be added on demand easily) - add some tests for ApplicationHelper and GlyphHelper

admin: user form: ensure orgs order by ID asc in membership selector

84505ec

RSpec.describe => describe for consistency across the suite; minor sp…

dd2170f

…ec_helper.rb edits

Partially revert 727a865:

898d6fe

- return to RSpec.describe as per #362 - manually print seed as we don't use "config.order = 'random'" (we're using a custom ordering) ~> more info. 94c50fb - [EXTRA] remove sudo in Travis

move alert_class to ApplicationHelper (+ minor refactor); use valid c…

761c7ff

…ss class in show_error_messages! helper

markets force-pushed the admin_orgs_order branch from 9b577ff to 761c7ff Compare June 21, 2018 19:57

markets commented Jun 21, 2018

View reviewed changes

Merge branch 'develop' into admin_orgs_order

1b8e97c

enricostano merged commit 52f889d into develop Aug 8, 2018

enricostano deleted the admin_orgs_order branch August 8, 2018 11:27

enricostano removed the needs testing label Aug 8, 2018

enricostano mentioned this pull request Aug 8, 2018

Release v1.6.0 #394

Merged

Admin organizations order #361

Admin organizations order #361

Uh oh!

Conversation

markets commented May 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enricostano May 20, 2018

Choose a reason for hiding this comment

Uh oh!

sauloperez May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rewritten commented May 21, 2018

Uh oh!

markets commented May 21, 2018

Uh oh!

rewritten commented May 22, 2018 via email

Uh oh!

enricostano May 22, 2018

Choose a reason for hiding this comment

Uh oh!

markets May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enricostano Jun 7, 2018

Choose a reason for hiding this comment

Uh oh!

markets Jun 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enricostano Jun 7, 2018

Choose a reason for hiding this comment

Uh oh!

markets Jun 10, 2018

Choose a reason for hiding this comment

Uh oh!

enricostano commented May 22, 2018

Uh oh!

sauloperez May 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markets Jun 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

enricostano commented Aug 8, 2018

Uh oh!

enricostano commented Aug 8, 2018

Uh oh!

Uh oh!

markets commented May 19, 2018 •

edited

Loading

sauloperez May 22, 2018 •

edited

Loading

markets May 22, 2018 •

edited

Loading

markets Jun 7, 2018 •

edited

Loading

sauloperez May 22, 2018 •

edited

Loading

markets Jun 21, 2018 •

edited

Loading