Allow to search users by member_uid #354
Conversation
| @@ -83,7 +83,7 @@ | |||
| ] | |||
| end | |||
|
|
|||
| config.include Devise::TestHelpers, type: :controller | |||
| config.include Devise::Test::ControllerHelpers, type: :controller | |||
|
Current build is "unstable" due to others test cases (not related to these changes), as noted by @rewritten in #351: cd25968. |
|
Take a look at @rewritten 's PR cause it looks like he's working on it. |
|
👍 seems that it was solved there, I'll rebase on top when it get merged to develop, because both branches are also touching the ransack form. |
Conflicts: app/views/users/index.html.erb
|
Updated from |
…ack/wiki/Using-Ransackers#4-convert-an-integer-database-field-to-a-string-in-order-to-be-able-to-use-a-cont-predicate-instead-of-the-usual-eq-which-works-out-of-the-box-with-integers-to-find-all-records-where-an-integer-field-id-in-this-example-contains-an-input-string) - Added sortable column on member_uid - Removed a couple of old comments
markets
force-pushed
the
search_member_uid
branch
from
a17471f to
22cda5d
Compare
|
@enricostano @sauloperez Finally CI is green ✅ 😃 Ready for review 👀 |
Conflicts: app/views/users/index.html.erb
|
Updated with latest |
|
I changed the label to "need review" because you didn't merge it and I can not test it |
|
Deployed on https://staging.timeoverflow.org/ |
|
Tested with @sseerrggii 🍏 |
Closes #343
Implemented using current search based on
Ransack. I followed this guide to map the integer to a char and make it work with the pg ILIKE.EXTRA Allow to sort by the
member_uidcolumn