remove outdated Vagrant + docs update #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…root folder + little docs tweaks
markets
force-pushed
the
vagrant_cleanup
branch
from
c438c45 to
63dede0
Compare
…eploys, ref: c7c3c77) => we use the .ruby-version file
sauloperez
approved these changes
Mar 18, 2018
enricostano
reviewed
Apr 3, 2018
| @@ -1,7 +1,5 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| ruby '2.3.0' | |||
| @@ -414,8 +414,5 @@ DEPENDENCIES | |||
| web-console (= 2.1.3) | |||
| whenever | |||
|
|
|||
| RUBY VERSION | |||
| ruby 2.3.0p0 | |||
|
|
|||
There was a problem hiding this comment.
I think we need both .ruby-version and a version specified in the Gemfile. The former will make rbenv, rvm or chruby to use the specified version and the latter will make it obvious that someone used a different ruby version (the check doesn't raise any error).
There was a problem hiding this comment.
Let's create an issue then!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #320
As commented in issue #320, would be really helpful for contributors to have only 1 Vagrant to prevent confusions, so I just removed the one hosted here in the same repo, as it's kind of "outdated".
In the contributing guidelines we point people to the wiki (Getting started page), and in that wiki page we mention the
coopdevs/timeoverflow-provisioning.Extra:
docs/folder and I've moved there other documentation related files (translations, images) in order to keep the root folder more clean and small.Let me know what do you think guys. Thanks!