Skip to content

Add staging environment #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 1, 2018
Merged

Add staging environment #314

merged 6 commits into from
Feb 1, 2018

Conversation

enricostano
Copy link
Contributor

@enricostano enricostano commented Jan 30, 2018

  • Add staging to config/secrets.yml


# Do not dump schema after migrations.
config.active_record.dump_schema_after_migration = false
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a copy of production's config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we need to change the mail sender though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do in another PR

if /^SMTP_(.*)$/ === k
[$1.downcase.to_sym, YAML.load(v)]
end
end.compact]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understand this, document it and add staging stuff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@enricostano enricostano removed the wip label Jan 31, 2018
@enricostano enricostano merged commit 94a4ad8 into develop Feb 1, 2018
@enricostano enricostano deleted the feature/staging branch February 1, 2018 10:54
sauloperez added a commit that referenced this pull request Feb 7, 2018
This reverts commit 94a4ad8, reversing
changes made to 6660a79.
sauloperez added a commit that referenced this pull request Feb 9, 2018
Matt-Yorkley pushed a commit to Matt-Yorkley/timeoverflow that referenced this pull request Jun 21, 2018
Matt-Yorkley pushed a commit to Matt-Yorkley/timeoverflow that referenced this pull request Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants