Fix favicon issue in staging

[enricostano]

It seems an issue valid only for https://staging.timeoverflow.org

We have 2 calls to favicon.ico:

timeoverflow/app/views/layouts/application.html.erb

Line 9 in d0f2bbf

<link href="/favicon.ico" rel="shortcut icon">

timeoverflow/app/views/layouts/report.html.erb

Line 12 in 8614f55

<link href="/favicon.ico" rel="shortcut icon">

but we don't have any favicon...

I, [2019-03-15T17:16:08.806952 #17899]  INFO -- : Started GET "/favicon.ico" for 66.249.66.154 at 2019-03-15 17:16:08 +0000
F, [2019-03-15T17:16:08.812329 #17899] FATAL -- : 
ActionController::RoutingError (No route matches [GET] "/favicon.ico"):
[...]

[enricostano]

@sseerrggii what should we do?

[markets]

@enricostano https://www.timeoverflow.org/favicon.ico it works for me. There is also a file in the repo: https://github.com/coopdevs/timeoverflow/blob/develop/public/favicon.ico

[sseerrggii]

Yes, it's only a staging server problem
I don't know why favicon don't load in staging 🤔

[enricostano]

@markets do you see a favicon in your browser? I don't 🤔

EDIT: I didn't see @sseerrggii 's comment... OK, we'll need to investigate in any case since staging is what we'll have in production once we finish the migration to Ubuntu 18. I'll add this info to the description. Thanks!

[enricostano]

Probably we should move this issue to https://github.com/coopdevs/timeoverflow-provisioning but I'm still not sure. We need to investigate a bit more.

[markets]

@enricostano yep, in production, I can see the favicon in the browser!

It seems, in staging, all files under public/ don't respond properly: https://staging.timeoverflow.org/robots.txt .... maybe nginx config in staging stage?

Another possibility:

config.serve_static_files = ENV['RAILS_SERVE_STATIC_FILES'].present?

We have ☝️ this setting, and probably the gem:

timeoverflow/Gemfile

Lines 70 to 72 in 6d9bbde

	group :production do
	gem 'rails_12factor', '0.0.3'
	end

makes that true, but only in production env. If this is the issue, I'd vote for removing the gem and just configure each env accordingly!

[enricostano]

I'd vote for removing the gem and just configure each env accordingly!

@markets aahhhh "removing"... you know my tastes 😂 🔥 I created a separate issue to investigate that lead: #485