Is this optimization really needed on password reset?

[enricostano]

I still don't understand what problem we were trying to solve.

Give a look at f8f9400

[sauloperez]

See my comment f8f9400

[juanjochi]

From what I understand it seems that you have to check that when asking for password recovery, you receive an email and you can change it correctly. I have requested the recovery three times, with Opera what I have detected is that the first took several minutes, the other two times the mail arrived in seconds. On the other hand I think that to facilitate the use could hide the button to send the mail again and the unlock and appear after pressing once the password reset button. I have tried from Firefox and it takes seconds to get the recovery mail.

[enricostano]

Maybe related https://github.com/coopdevs/timeoverflow/blob/develop/config/initializers/devise.rb#L187

[markets]

What are you suggesting @enricostano to increase or decrease that number? Would be amazing to fix this (and remove memcached 😛) by just tweaking Devise settings.

Another possible approach: to sort out this by db, with something like ¯_(ツ)_/¯:

def set_reset_password_token
  return reset_password_token if reset_password_sent_at < RESET_PASSWORD_TOKEN_LAZINESS.ago
  super
end

Instead of the current:

timeoverflow/app/models/concerns/lazy_recoverable.rb

Lines 11 to 17 in e6ef119

	def set_reset_password_token
	# Just cache it! :)
	cache_key = "reset_password_token_hash:#{self.reset_password_token}"
	Rails.cache.fetch(cache_key, expires_in: RESET_PASSWORD_TOKEN_LAZINESS) do
	super
	end
	end

But, as we discussed several times, instead of new patches:

🔪 if possible

[enricostano]

I would like to try out Devise settings tuning... and remove the cache.

[markets]

@sseerrggii can we just delete this? I'd take care of the ✂️ but I want to confirm first ...

This was added in the past because people are getting different emails (multiple clicks) and only the last one is valid (to reset the pass). But nowadays most of emails clients have good UI for threads/groups, so maybe we can just 🔥 this optimization (=> and remove the entire cache gem and infra piece).

We can also tune this setting if you want:

# Time interval you can reset your password with a reset password key.
# Don't put a too small interval or your users won't have the time to
# change their passwords.
config.reset_password_within = 6.hours

If we receive any kind of negative feedback, we can eventually solve it in a different way, like adding proper messages in the UI, hide the button, or something... but would be amazing to ✂️ this :)

[markets]

Just in case @sseerrggii confirms 😛 👉 #517 ✂️ ✂️ ✂️

[sseerrggii]

I'm agree, we can remove this optimization! I should close this issue @markets ?

[markets]

:):):):) 👍👍👍

Not necessary to close it now, it will be automatically closed by #517.