Pass env vars to dynamic app configuration & build APKs #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not immediately obvious on https://docs.expo.dev/guides/environment-variables/, but it turns out that for ENV vars specified in the eas.json's profiles to be read from `Constants.expoConfig.extra`, the app configuration needs to be dynamic and set them from `process.env`. This fixes the issue we were trying to solve on https://github.com/coopdevs/timeoverflow-mobile-app/pull/14/files#diff-9b5b5955d0e684e7904f3fc143e07aaa11b7e7c3b36d10985c4aff2554940cbfR24. Besides, using dynamic configuration gives more options to better adapt it to our needs. Check https://docs.expo.dev/workflow/configuration/ for details.
Otherwise we won't be able to publish this build to the Play Store.
|
I just checked it again and the build does point to production 👌 , and it's also an APK. |
sauloperez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not immediately obvious on
https://docs.expo.dev/guides/environment-variables/, but it turns out that for ENV vars specified in the eas.json's profiles to be read from
Constants.expoConfig.extra, the app configuration needs to be dynamic and set them fromprocess.env.This fixes the issue we were trying to solve on
https://github.com/coopdevs/timeoverflow-mobile-app/pull/14/files#diff-9b5b5955d0e684e7904f3fc143e07aaa11b7e7c3b36d10985c4aff2554940cbfR24.
Besides, using dynamic configuration gives more options to better adapt it to our needs. Check https://docs.expo.dev/workflow/configuration/ for details.