Prove of concept to store the push notifications token #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morantron
reviewed
Feb 21, 2018
lib/pushNotifications.js
Outdated
|
|
||
| // Get the token that uniquely identifies this device | ||
| let token = await Notifications.getExpoPushTokenAsync(); | ||
|
|
||
| console.log('user token', token); | ||
| cb(token); |
There was a problem hiding this comment.
No need for callback, you can return the token and await registerForPushNotificationsAsync() when consuming this function.
mllocs
force-pushed
the
feature/push-token-storing
branch
from
e803d29 to
03e3a7c
Compare
sauloperez
approved these changes
Feb 27, 2018
Morantron
reviewed
Feb 27, 2018
| this.runRemoteTokenStoring(token); | ||
| } | ||
|
|
||
| onNavigationStateChange({ url }) { |
There was a problem hiding this comment.
You can do the following, to avoid binding to this on the render method. It's magic.
- onNavigationStateChange({ url }) {
+ onNavigationStateChange = ({url}) => {
+ ...
+ }
There was a problem hiding this comment.
wat?! can you explain that? I'm just a poor rubyist trying to understand this...
There was a problem hiding this comment.
haha, maybe the current syntax is more accessible then :P
There was a problem hiding this comment.
I shouldn't be the one taken as example 
enricostano
approved these changes
Feb 27, 2018
sauloperez
added a commit
to sauloperez/my-app
that referenced
this pull request
Aug 28, 2022
sauloperez
added a commit
that referenced
this pull request
Oct 1, 2022
Note this also stores the device token in the backend. This ports #1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here there's a Proof of Concept of storing the Expo device token in our backend. For that, we execute the
TimeOverflowRegisterExpoDeviceTokenlibrary in the WebView when the user is Logged In. For that we use theinjectJavascriptmethod which allows you to inject JS in the WebView.Related:
coopdevs/timeoverflow#329
https://github.com/coopdevs/timeoverflow/pull/329/files#diff-c1bb3091d6fc642a5ea8502be0ef07feR1