fix(ui): toggle password visibility icon based on state #7729
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The eye icon now correctly toggles between eye and eye-off states when clicking the password visibility toggle button. Previously, the icon remained static even though the password visibility changed. Changes: - Add eye-off SVG icon for when password is visible - Use Alpine.js x-show directive to conditionally display appropriate icon - Update click handler to toggle type state for icon synchronization Fixes coollabsio#7721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the password show/hide icon not toggling correctly when clicking the visibility button.
Problem
The eye icon remained static even when the password visibility state changed. This was confusing for users as there was no visual feedback from the toggle button.
Solution
Affected Pages
Fixes #7721