-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEMPLATE] Add GitLab template #2638
Conversation
HEllo @GunniBusch , I think we also need to Add these as well SMH
Gitlab Has support for PostgreSQL database. with - DB_ADAPTER=postgresql I think it would be wise to Have these Implemented as well |
Based on your implementaqtion would be more like
|
At least for the db values, I took the git tea as a template for this, which also does not have a separate db. |
Maybe an idea for a separate template? |
SO we basically Have 2 VErsions, One with integrated DB within the container, WHile another one where the DB is Separate from the Main container? How About the other ENv variables, are they not required as well, SMTP, keys and passwords, etc |
so the thing is that settings set by the OMNi ... env var are (so how I understood it) are not meant for the first config. They can be configured also by entries in a conf file and using the ui. So but I have now fixed how to correctly set these variables. So I am now testing if it works and commit the changes |
the next thing is should I also create a template for the ee as well? |
I added the mail config. I seems to work. But can someone try it to verify? |
EE version is not necessary at the moment, The focus would be the PGSQL as seprate db version first |
could we add these as well: timezone ##Additional for EMails
I believe them to be basic configs that majority would want to use, if configured. |
Thank you for the PR! It will need a few fine-tunes, but I wrap it up. |
Thank you, let me pay up the bounty... |
Added a gitlab template
Fixes #2635
/claim #2635