Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests in GH Actions #2623

Closed
wants to merge 18 commits into from
Closed

Conversation

Thijmen
Copy link
Contributor

@Thijmen Thijmen commented Jun 21, 2024

This PR adds support for running unit tests in Pull Request pipelines.

@Thijmen
Copy link
Contributor Author

Thijmen commented Jun 21, 2024

@andrasbacsai Can you approve this workflow? I've tested it first here: Thijmen/github-actions-testing#1

I am keen on understanding if this works for this repo.

@Thijmen
Copy link
Contributor Author

Thijmen commented Jun 24, 2024

Let me dig into this as to why this is not working. I'll ping you once I think it's fixed.

@Thijmen
Copy link
Contributor Author

Thijmen commented Jun 24, 2024

@andrasbacsai I made a small mistake by copying it from my repo, I've updated the action now to execute the proper docker-compose service.

@Thijmen
Copy link
Contributor Author

Thijmen commented Jun 24, 2024

@andrasbacsai Can you approve the workflow, so we can see if it works?

@Thijmen
Copy link
Contributor Author

Thijmen commented Jun 26, 2024

It's ready for another swing @andrasbacsai :)

@andrasbacsai andrasbacsai marked this pull request as ready for review June 27, 2024 20:57
@Thijmen
Copy link
Contributor Author

Thijmen commented Jul 2, 2024

@andrasbacsai Can you run the tests, so we know if it works?

Copy link

gitguardian bot commented Jul 2, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - GitHub App Keys ccbbfd8 database/seeders/GithubAppSeeder.php View secret
- - Generic Password e1bcae7 templates/compose/resend.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@andrasbacsai
Copy link
Member

I will close this PR for inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants