-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests in GH Actions #2623
Conversation
@andrasbacsai Can you approve this workflow? I've tested it first here: Thijmen/github-actions-testing#1 I am keen on understanding if this works for this repo. |
Let me dig into this as to why this is not working. I'll ping you once I think it's fixed. |
@andrasbacsai I made a small mistake by copying it from my repo, I've updated the action now to execute the proper docker-compose service. |
@andrasbacsai Can you approve the workflow, so we can see if it works? |
It's ready for another swing @andrasbacsai :) |
@andrasbacsai Can you run the tests, so we know if it works? |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | GitHub App Keys | ccbbfd8 | database/seeders/GithubAppSeeder.php | View secret |
- | - | Generic Password | e1bcae7 | templates/compose/resend.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
I will close this PR for inactivity. |
This PR adds support for running unit tests in Pull Request pipelines.