Fixes youtube player playsinline variable type - #989
Merged
cookpete merged 1 commit intoAug 21, 2020
Conversation
|
Maybe you could update the types defined in |
Owner
|
Thanks for the PR @gregorybolkenstijn ! @storyworks There is no need to change the types. The prop is still a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this bug when embedding a Youtube player on Safari mobile. Passing true would create
playsinline=true, which didn't enable the inline playback. I could fix it by passing1as value, but then I got this warning:Warning: Failed prop type: Invalid prop 'playsinline' of type 'number' supplied to 'Player', expected 'boolean'.playsinlineshould be a number as per the Youtube player documentation: https://developers.google.com/youtube/player_parameters#playsinlineValid values are:
0: This value causes fullscreen playback. This is currently the default value, though the default is subject to change.
1: This value causes inline playback for UIWebViews created with the allowsInlineMediaPlayback property set to TRUE.