Skip to content

Fix twitch permanent loading state when stream is offline #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cookpete merged 3 commits into from
Jun 5, 2019
Merged

Fix twitch permanent loading state when stream is offline #657

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e2cac4
twitch permanent loading state stream is offline
May 30, 2019
40c96d9
add online condition
May 30, 2019
795bbdd
Tidy up comments
cookpete Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/players/Twitch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@ export class Twitch extends Component {
muted: this.props.muted,
...config.twitch.options
})
const { READY, PLAYING, PAUSE, ENDED } = Twitch.Player
const { READY, PLAYING, PAUSE, ENDED, ONLINE, OFFLINE } = Twitch.Player
this.player.addEventListener(READY, this.props.onReady)
this.player.addEventListener(PLAYING, this.props.onPlay)
this.player.addEventListener(PAUSE, this.props.onPause)
this.player.addEventListener(ENDED, this.props.onEnded)

// Prevent weird isLoading behaviour when streams are offline
this.player.addEventListener(ONLINE, this.props.onLoaded)
this.player.addEventListener(OFFLINE, this.props.onLoaded)
}, onError)
}
play () {
Expand Down