fix: prevent React warnings for unknown event handler properties #1970
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filter out ReactPlayer-specific event handlers (onReady, onStart, onPlay, onPause, onEnded, onLoadStart) before passing props to underlying player component - Prevents React warnings about "Unknown event handler property" - Maintains full functionality while eliminating console warnings - Added comprehensive tests to verify the fix - Backward compatible with no breaking changes
luwes
reviewed
Aug 7, 2025
ryanburst
had a problem deploying
to
github-preview
GitHub Actions
Failure
Co-authored-by: Wesley Luyten <me@wesleyluyten.com>
ryanburst
had a problem deploying
to
github-preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses React warnings about "Unknown event handler property" for ReactPlayer-specific event handlers (onReady, onStart, onPlay, onPause, onEnded, onLoadStart) by filtering them out before passing props to the underlying HTML video element.
The issue was that all props starting with "on" were being passed down to the underlying player component, including ReactPlayer-specific event handlers that don't exist on HTML video elements.
This fix filters out ReactPlayer-specific event handlers while preserving standard HTML video event handlers, eliminating console warnings without breaking functionality.
Added test to verify the fix works correctly.