fix: empty src attr in StrictMode - #1538
Conversation
|
same, experiencing the same issue here, fix would be awesome! |
|
same problem here. the fix would be welcome |
|
I got the same problem and the fix works. |
|
@cookpete Hi, we would appreciate it if you could review the fix |
|
Yup! This is the "Fix" 🚀 |
|
Has anyone seen @cookpete on a ticket or git in the last few months? Maybe he has abandoned the repo (or is no longer able to manage it) and it's time to fork? |
|
I’m here. I’m alive. It’s been over seven years since I started this project. I never thought it would become this popular. Life changes a lot in seven years. I have much less free time now. I would love to spend more time on this. I will try to in the future. Bear with me. Apologies to keep everyone waiting for so long. |
|
@cookpete No worries, thanks a lot for your continued support! |
|
Thanks to @Gerpea for the original fix but it’s actually as simple as setting the The original fix would have called Regardless, thanks so much for the PR and pointing me in the right direction to fix this. |
|
🎉 Thank you @cookpete |
|
@cookpete Thank you for the fix. In which version will this fix come? |
|
Published in |
…urls PR cookpete#1538 was setting the src of the video element to undefined. Because of this, even if the users passed an array of urls, the video element would not play becuase it got a `src` of `undefined`; After fixing the undefined `src` issue, another PR was making a infinite loop issue when user passed an array of urls. There, the author set the `srcObject` to null. There as well, a check for `url` prop was missing. This PR aims to fix both of these overlooked aspects.
…urls PR cookpete#1538 was setting the src of the video element to undefined. Because of this, even if the users passed an array of urls, the video element would not play becuase it got a `src` of `undefined`; After fixing the undefined `src` issue, another PR was making a infinite loop issue when user passed an array of urls. There, the author set the `srcObject` to null. There as well, a check for `url` prop was missing. This PR aims to fix both of these overlooked aspects.
) PR #1538 was setting the src of the video element to undefined. Because of this, even if the users passed an array of urls, the video element would not play becuase it got a `src` of `undefined`; After fixing the undefined `src` issue, another PR was making a infinite loop issue when user passed an array of urls. There, the author set the `srcObject` to null. There as well, a check for `url` prop was missing. This PR aims to fix both of these overlooked aspects.
10 participants
This should fix v2.11.0 not playing MP4 URL files #1530 React player is not loading the video initially #1520 src is not set when using file #1508