-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to webpack v5 #1225
Migrate to webpack v5 #1225
Conversation
I would like to hear your opinion @cookpete regarding my attempts to upgrade everything. I couldn't find anything that broke after my adjustments and am open to suggestions. |
As mentioned in cookpete#1225 `findDOMNode` is deprecated.
Funnily enough I was considering moving everything to a |
I am myself not really familiar with bundling and publishing myself. But if it can be done vie |
* Adjust listener for kaltura Fixes #1202 and related to #1082. * Fix lint As mentioned in #1225 `findDOMNode` is deprecated. * Add autoplay to iframe props * Move code to load method and call it instead * Update src/players/Kaltura.js Co-authored-by: Pete Cook <pete@cookpete.com> * Remove `this.load()` call in `componentDidMount` Co-authored-by: Pete Cook <pete@cookpete.com>
closed by #1684 |
Migrated to webpack v5 from v4 and upgraded dependencies to latest.
yarn outdated
listed:Deps-changes
postcss-loader
andpostcss-nested
>=5 devDependencypostcss
>=8 had to be added to devDepDemo App
webpack-dev-server
deprecated and should now be called viawebpack serve
findDOMNode
has been long deprecated, needed to adjust fullscreen example in demoimport { version } from '../../package.json'
throws warning:Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)
, replaced it withimport metadata from '../../package.json'
ts lint with react
React now requires (or strongly encourages you) to use null safety, added to
.tsconfig
webpack config
query
property has been removed from v5 and replaced it with usequery-string like loader
'file-loader?name=assets/[hash].[ext]'
is disallowed, moved it to use propertyTerserPlugin
optionsourceMap
has been restructured and needed to be moved toterserOptions
default versions
hls
0.14.16
->1.0.2
dash
3.1.3
->3.2.2
flv already up to date
adjusted notice in
README.md
Fixes #1215
Other deprecation warning:
(node:8465) [DEP_WEBPACK_COMPILATION_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: optimizeChunkAssets is deprecated (use Compilation.hooks.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)