Manage vpc-cni, coredns and kube-proxy via eks addons #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidy
force-pushed
the
aidy/eks-addons
branch
2 times, most recently
from
5c19db2
to
989ef33
Compare
aidy
changed the title
ettiee
approved these changes
Nov 29, 2021
|
989ef33 removes a variable so probably worth documenting in |
hmm, so - my normal approach is to have sane, atomic, commits - and then to merge the commits, rather than squash. Perhaps it's worth rewording 821d95f to have some reasoning for the motivation for this change. Would that work for you? |
ettiee
approved these changes
Dec 1, 2021
Oh, yes. (That should probably have been a whole different PR - but we're here now) |
For the switch to using eks_addons, we'll need to ensure that nodes are up and running before trying to provision them. Otherwise we end up in a race condition and get errors of the kind: ``` Error: unexpected EKS Add-On (terraform-aws-eks-testing-jPfg0J:coredns) state returned during creation: unexpected state 'DEGRADED', wanted target 'ACTIVE'. last error: %!!(MISSING)s(<nil>) ```
https://docs.aws.amazon.com/eks/latest/userguide/eks-add-ons.html This makes a start on our reconsideration of addons - #224 Where available, we'd prefer to use eks addons rather than set them up ourselves.
EKS and the node AMIs are using the same logic to calculate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.