Fixes #12 Add missing ominauth require #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
The mentioned issue happens when
omniauth
is not added explicitly to Gemfile, hence bundler does not require it.But since
omniauth-rails_csrf_protection
assumes theominauth
is already required, it errors out when user only addsomniauth-rails_csrf_protection
but does not addomniauth
toGemfile
.This PR adds missing
require
foromniauth
gem.Bug script:
Log
Update bug script with this PR:
Log
``` require 'bundler/inline'gemfile(true) do
source "https://rubygems.org"
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
gem "rails", '7.0.0.alpha2'
gem 'omniauth-rails_csrf_protection', git: 'https://github.com/the-spectator/omniauth-rails_csrf_protection', branch: 'fix_missing'
end
class TestApp < Rails::Application
config.root = dir
config.eager_load = false
end
ENV["DATABASE_URL"] = "sqlite3::memory:"
Rails.application.initialize!