Do not send event hash to WebSocket clients

coocos · Apr 10, 2021 · 9aae77b · 9aae77b
1 parent eecfae4
commit 9aae77b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/poll.ts b/src/poll.ts
@@ -6,7 +6,7 @@ import { events, RescueEvent } from "./services/events";
 import { fetchFeedEvents } from "./services/feed";
 
 export const pollFeed = (
-  eventCallback: (event: RescueEvent) => void
+  eventCallback: (event: Omit<RescueEvent, "hash">) => void
 ): cron.ScheduledTask => {
   const task = cron.schedule(config.feed.schedule, async () => {
     try {
@@ -15,7 +15,11 @@ export const pollFeed = (
         if (!(await events.exists(event))) {
           logger.info("New event", event);
           await events.add(event);
-          eventCallback(event);
+          eventCallback({
+            location: event.location,
+            time: event.time,
+            type: event.type,
+          });
         }
       }
     } catch (err) {

diff --git a/src/server.integration.test.ts b/src/server.integration.test.ts
@@ -102,13 +102,11 @@ describe("Server", () => {
             type: "rakennuspalo: pieni",
             location: "Kokkola",
             time: "2021-03-01T15:59:04.000Z",
-            hash: "c7aae8a31f3d31d228aa33368be142663bad9577",
           },
           {
             type: "rakennuspalo: pieni",
             location: "Helsinki",
             time: "2021-03-01T15:40:52.000Z",
-            hash: "169a28a0c1979d7c105490bde4e30ce5b64418a5",
           },
         ]);
         client.close();

diff --git a/src/websocket/server.test.ts b/src/websocket/server.test.ts
@@ -22,7 +22,6 @@ describe("WebSocket server", () => {
         type: "rakennuspalo: keskisuuri",
         location: "Tuusula",
         time: new Date("2021-01-31T22:00:00.000Z"),
-        hash: "2a39407ee0570aae8f3ba2842e11aa28ce0f5d9f",
       });
     });
     client.on("message", (data) => {
@@ -31,7 +30,6 @@ describe("WebSocket server", () => {
         type: "rakennuspalo: keskisuuri",
         location: "Tuusula",
         time: "2021-01-31T22:00:00.000Z",
-        hash: "2a39407ee0570aae8f3ba2842e11aa28ce0f5d9f",
       });
       client.close();
       done();