Support ECS clusters based on X2gd instances #3641
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 36.04% // Head: 36.04% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #3641 +/- ##
=======================================
Coverage 36.04% 36.04%
=======================================
Files 168 168
Lines 18536 18536
=======================================
Hits 6682 6682
Misses 10717 10717
Partials 1137 1137 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
thanks @kyleroot for the contribution :D |
Twsouza
added a commit
that referenced
this pull request
Feb 7, 2023
### What is the feature/fix? ** Describe the task and what is the goal for it. ** To deploy a Convox v2 cluster onto "memory-intensive" instances. The CloudFormation template supports R6g instances, however X2gd instances are much cheaper. ** Describe the bug and the solution. ** I tried to deploy a cluster onto x2gd instances and was foiled by the mechanism for detecting when an Arm cluster is being deployed not including the x2gd family. Simply adding the x2gd (there is no x2g.* class) prefix to the existing InstanceARM conditional. ** Any additional information ** N/A ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** N/A ### Does it has a breaking change? No. ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? ** Describe how to test or use the feature ** Create a new cluster on x2gd instances. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Twsouza
added a commit
that referenced
this pull request
Feb 8, 2023
### What is the feature/fix? ** Describe the task and what is the goal for it. ** To deploy a Convox v2 cluster onto "memory-intensive" instances. The CloudFormation template supports R6g instances, however X2gd instances are much cheaper. ** Describe the bug and the solution. ** I tried to deploy a cluster onto x2gd instances and was foiled by the mechanism for detecting when an Arm cluster is being deployed not including the x2gd family. Simply adding the x2gd (there is no x2g.* class) prefix to the existing InstanceARM conditional. ** Any additional information ** N/A ### Add screenshot or video (optional) ** Any screenshot or video capture using the feature ** N/A ### Does it has a breaking change? No. ** Describe the changes and if it has any breaking changes in any feature ** ### How to use/test it? ** Describe how to test or use the feature ** Create a new cluster on x2gd instances. ### Checklist - [ ] New coverage tests - [ ] Unit tests passing - [ ] E2E tests passing - [ ] E2E downgrade/update test passing - [ ] Documentation updated - [ ] No warnings or errors on Deepsource/Codecov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature/fix?
** Describe the task and what is the goal for it. **
To deploy a Convox v2 cluster onto "memory-intensive" instances. The CloudFormation template supports R6g instances, however X2gd instances are much cheaper.
** Describe the bug and the solution. **
I tried to deploy a cluster onto x2gd instances and was foiled by the mechanism for detecting when an Arm cluster is being deployed not including the x2gd family. Simply adding the x2gd (there is no x2g.* class) prefix to the existing InstanceARM conditional.
** Any additional information **
N/A
Add screenshot or video (optional)
** Any screenshot or video capture using the feature **
N/A
Does it has a breaking change?
No.
** Describe the changes and if it has any breaking changes in any feature **
How to use/test it?
** Describe how to test or use the feature **
Create a new cluster on x2gd instances.
Checklist