-
Notifications
You must be signed in to change notification settings - Fork 2
Fixed direct video links not rendering correctly. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed direct video links not rendering correctly. #26
Conversation
Added webp and webm formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great in general. Just need some tweaks.
Thanks for the contribution!
I did a round of changes and fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rebase and merge this once you have pressed the "Ready for review" button 👍
Feel free to make more changes though, if you want to.
I think I did most of what I was planning. I was wondering if there's something else needed to better integrate the changes in convos... but I do not know the code base well enough to give an informed opinion about that. |
Not sure what that would be, but please let me know if you have any specific ideas. |
- Fix Mojolicious version after v1.18 #23 - Fix direct video links not rendering correctly #26 Contributor: Bruno Ramos - Fix Metacpan author_name detection and tests #29 Contributor: Bruno Ramos - Add paste.debian.net support #19 #28 Contributor: Bruno Ramos - Add support for https://youtu.be links #25 #27 Contributor: Bruno Ramos
Fixed direct video links not rendering correctly.
Added webp and webm formats.
Direct video links[1][2] were not being rendered correctly and I were always showing a message:
Your browser does not support the video tag.
I did some changes to correctly create a
<div><video><source>
structure so that the video is rendered correctly.Still need to update the tests in basic.t and clean up the
%for
in the video.html.ep template.And the video is being rendered at 100%, so that needs some cleanup too (review class and width/height).
Could you please take a look already to see if you understand what I did?
Maybe provide some guidance/comments?
[1] https://www.learningcontainer.com/wp-content/uploads/2020/05/sample-mp4-file.mp4
[2] https://dl8.webmfiles.org/big-buck-bunny_trailer.webm