Skip to content

Fixed direct video links not rendering correctly. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2021

Conversation

brunoramoslu
Copy link
Contributor

Fixed direct video links not rendering correctly.
Added webp and webm formats.


Direct video links[1][2] were not being rendered correctly and I were always showing a message:
Your browser does not support the video tag.

I did some changes to correctly create a <div><video><source> structure so that the video is rendered correctly.
Still need to update the tests in basic.t and clean up the %for in the video.html.ep template.
And the video is being rendered at 100%, so that needs some cleanup too (review class and width/height).

Could you please take a look already to see if you understand what I did?
Maybe provide some guidance/comments?

[1] https://www.learningcontainer.com/wp-content/uploads/2020/05/sample-mp4-file.mp4
[2] https://dl8.webmfiles.org/big-buck-bunny_trailer.webm

Copy link
Collaborator

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great in general. Just need some tweaks.

Thanks for the contribution!

@brunoramoslu
Copy link
Contributor Author

I did a round of changes and fixed the basic.t tests.
I'm checking it it was me who broke the other test... I'm having failures when using TEST_ONLINE=1 on some others tests.

Copy link
Collaborator

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase and merge this once you have pressed the "Ready for review" button 👍
Feel free to make more changes though, if you want to.

@brunoramoslu
Copy link
Contributor Author

I think I did most of what I was planning.
I'm glad to accommodate any other suggestions.
If there's nothing else you would like changed related to this, feel free to accept it.

I was wondering if there's something else needed to better integrate the changes in convos... but I do not know the code base well enough to give an informed opinion about that.

@brunoramoslu brunoramoslu marked this pull request as ready for review June 4, 2021 21:46
@brunoramoslu brunoramoslu changed the title WIP: Fixed direct video links not rendering correctly. Fixed direct video links not rendering correctly. Jun 4, 2021
@jhthorsen
Copy link
Collaborator

I was wondering if there's something else needed to better integrate the changes in convos... but I do not know the code base well enough to give an informed opinion about that.

Not sure what that would be, but please let me know if you have any specific ideas.

@jhthorsen jhthorsen merged commit a74b2f0 into convos-chat:master Jun 9, 2021
jhthorsen pushed a commit that referenced this pull request Jun 9, 2021
 - Fix Mojolicious version after v1.18 #23
 - Fix direct video links not rendering correctly #26
   Contributor: Bruno Ramos
 - Fix Metacpan author_name detection and tests #29
   Contributor: Bruno Ramos
 - Add paste.debian.net support #19 #28
   Contributor: Bruno Ramos
 - Add support for https://youtu.be links #25 #27
   Contributor: Bruno Ramos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants