Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize chapter posts w/ one more hierarchy #141

Merged
merged 4 commits into from
May 23, 2021
Merged

Organize chapter posts w/ one more hierarchy #141

merged 4 commits into from
May 23, 2021

Conversation

hunhoon21
Copy link
Collaborator

  • 합치게 되면 이런 모양새입니다.

As is

image

Tobe

image
image

@hunhoon21
Copy link
Collaborator Author

이에 따라 conventions 파트도 일부 수정 했습니다
image
#96

@Curt-Park
Copy link
Collaborator

Curt-Park commented May 23, 2021 •
edited
Loading

보기에 훨씬 깔끔하네요.
URL이 변경될 것이므로 문서 내의 하이퍼링크 주소의 수정도 필요할 것 같습니다.

@Curt-Park Curt-Park changed the title one more hierarchy to organize chapter posts Organize chapter posts w/ one more hierarchy May 23, 2021
@hunhoon21
Copy link
Collaborator Author

보기에 훨씬 깔끔하네요.
URL이 변경될 것이므로 문서 내의 하이퍼링크 주소의 수정도 필요할 것 같습니다.

관련된 URL은 전부 수정한 버젼입니다

@Curt-Park
Copy link
Collaborator

README의 URL도 수정했습니다.

@Curt-Park
Copy link
Collaborator

Convention 문서의 file structure 수정

스크린샷 2021-05-23 오후 6 05 12

Curt-Park
Curt-Park approved these changes May 23, 2021
View reviewed changes
Copy link
Collaborator

@Curt-Park Curt-Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hunhoon21 hunhoon21 merged commit edcda94 into main May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Curt-Park Curt-Park Curt-Park approved these changes

@RRoundTable RRoundTable Awaiting requested review from RRoundTable RRoundTable is a code owner

@YoungJaeChoung YoungJaeChoung Awaiting requested review from YoungJaeChoung YoungJaeChoung is a code owner

@enfow enfow Awaiting requested review from enfow enfow is a code owner

@LEEMINJOO LEEMINJOO Awaiting requested review from LEEMINJOO LEEMINJOO is a code owner

Assignees

@hunhoon21 hunhoon21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunhoon21 @Curt-Park