-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add featured course card component #294
feat: add featured course card component #294
Conversation
abf4123
to
97ad993
Compare
Did you branch it off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2c6997f
to
6e4a408
Compare
I believe we should be leveraging more of the benefits that custom elements provide us. Rather than defining the entire template as slotted content, I feel the template should be defined within the component and data passed in. We can be limited when the data is a list, generated html, or long content though other parts should be defined within the shadow dom. Ideally it would look like this:
This would allow us to scope CSS as much possible, as well as reduce the amount of data downloaded (the custom element would be responsible for rendering most of the HTML.) |
Sorry for intruding a bit here. On top of @anoblet suggestions, which I agree with, this design is very, very similar to the cxl-course theme. And the lightweight card can easily be achieved by just hiding a couple sections from the other similar components. My suggestion would be to briefly go over the figma designs marked as ready, and come up with a revised list of components that are each related to one clickup task and one pull request. Consolidating design variations under the same component will probably avoid a lot of headaches in the future. |
I agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar conclusion as in #289 (comment)
TODO: create new cxl-featured-course
component.
e0dbfd0
to
8fa92d6
Compare
6e4a408
to
3958587
Compare
3958587
to
963d389
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
963d389
to
a8c072b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a8c072b
to
c9fead6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
Next step: refactor to use cxlBaseCardElement
c9fead6
to
22e917d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1e24a8d
to
ae84730
Compare
@kertuilves I just merged #289, please rebase this branch, then I'll do (final) review :) |
ae84730
to
1750577
Compare
https://app.clickup.com/t/861n0qjha