Skip to content

No way to set old values when element has been removed from the model. #266

@mmacfadden

Description

@mmacfadden

Versions

  • Convergence Version: 1.0.0-rc.12

Describe the Bug
The code here:

https://github.com/convergencelabs/convergence-server/blob/8ded7fa5adaac3690520c98f53b0843072adab7d/src/main/scala/com/convergencelabs/convergence/server/backend/services/domain/model/RealtimeModel.scala#L239

Will insert None values or bogus values into the applied operations if the operation is noop'ed and the real time element is not in the model anymore.

Expected Behavior
We have discussed potentially keeping deleted elements around in a recycle bin while conflicting operations could still come in.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions