feat: support for reservations - #5
Merged
Merged
Conversation
Since fluxion is single threaded, we need to ensure the maxWorkers is 1, and a single job to cancel reservations is issued at the end of each batch group of jobs (that are issuing calls to AskFlux to schedule work). For the final job to clear reservations, we retrieve them from the reservation table, issue a cancel to fluxion for each one, and then clear the rows of the table as we go. This ensures that if there is an error to cancel a job it will be tried again in the next loop. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
add-reservations
branch
from
January 18, 2025 17:46
90ca8fe to
c7063be
Compare
Also ensure that cleanup max attempts is 3 and not infinite retry (which we have for the schedule function, essentially). Signed-off-by: vsoch <vsoch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since fluxion is single threaded, we need to ensure the maxWorkers is 1, and a single job to cancel reservations is issued at the end of each batch group of jobs (that are issuing calls to AskFlux to schedule work). For the final job to clear reservations, we retrieve them from the reservation table, issue a cancel to fluxion for each one, and then clear the rows of the table as we go. This ensures that if there is an error to cancel a job it will be tried again in the next loop.