wip: update to user mcp-server #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: an approach that hard codes functions and the base server is brittle. Solution: use common mcp-server backend. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
update-with-mcp-server
branch
from
954f2ee to
f39ae6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: an approach that hard codes functions and the base server is brittle.
Solution: use common mcp-server backend.
Note this is currently using this branch: converged-computing/mcp-server#6 that adds a few functions to better expose adding the custom arguments. The server looks the same:
But is entirely created from mcp-server and with a config file
mcpserver.yaml. The args are also added from mcpserver.I'm heading out the door but will pick up on this later. My plan is to test a bit more, merge these PRs, and then work on the wh layer.