Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): Add section for signing commits and tags #97

Merged
merged 2 commits into from
Aug 25, 2016
Merged

docs(readme): Add section for signing commits and tags #97

merged 2 commits into from
Aug 25, 2016

Conversation

JaKXz
Copy link
Contributor

@JaKXz JaKXz commented Aug 24, 2016

Resolves #94.

@coveralls
Copy link

coveralls commented Aug 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 94.937% when pulling f488cf3 on JaKXz:docs/sign into 8c93955 on conventional-changelog:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.937% when pulling f488cf3 on JaKXz:docs/sign into 8c93955 on conventional-changelog:master.

bcoe
bcoe reviewed Aug 24, 2016
View reviewed changes
README.md
@@ -107,6 +107,9 @@ npm run release -- --no-verify
standard-version --no-verify
```

### Signing commits and tags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the nit, but mind adding a space below the heading, I think this might cause issues for some markdown renderers.

@coveralls
Copy link

coveralls commented Aug 24, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 94.937% when pulling 78839f1 on JaKXz:docs/sign into 8c93955 on conventional-changelog:master.

@JaKXz
Copy link
Contributor Author

JaKXz commented Aug 24, 2016

@bcoe fixed :)

@stevemao
Copy link
Member

Thanks @JaKXz ! I thought the docs was updated. LGTM

@bcoe bcoe merged commit 1ad772a into conventional-changelog:master Aug 25, 2016
@JaKXz JaKXz deleted the docs/sign branch August 25, 2016 03:42
@Tapppi
Copy link
Member

Tapppi commented Aug 25, 2016

Thanks @JaKXz!

@gr00nd gr00nd mentioned this pull request Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaKXz @coveralls @stevemao @Tapppi @bcoe