Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial validation of custom updaters #942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: initial validation of custom updaters
  • Loading branch information
davidgoitia committed Jun 19, 2023
commit 5635d131542fb55f5258efcd3197513121b317d9
6 changes: 3 additions & 3 deletions lib/updaters/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ module.exports.resolveUpdaterObjectFromArgument = function (arg) {
* of the updater.
*/
let updater = arg
if (isValidUpdater(updater)) {
return updater
}
if (typeof updater !== 'object') {
updater = {
filename: arg
}
}
if (typeof updater.updater === 'object' && isValidUpdater(updater.updater)) {
return updater
}
try {
if (typeof updater.updater === 'string') {
updater.updater = getCustomUpdaterFromPath(updater.updater)
Expand Down