-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add parser opts #821
Open
mmamedel
wants to merge
6
commits into
conventional-changelog:master
Choose a base branch
from
mmamedel:feat-add-parser-opts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat add parser opts #821
mmamedel
wants to merge
6
commits into
conventional-changelog:master
from
mmamedel:feat-add-parser-opts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taraskuprunets
pushed a commit
to taraskuprunets/standard-version
that referenced
this pull request
Sep 29, 2021
Would love for this to be merged, the last thing missing before I can use |
naimahnash
reviewed
Nov 12, 2021
Co-authored-by: Naimah Nash <naimahnash@gmail.com>
Is there any plan to accept writerOpts as arguments(#362) in standard-version similar to parserOpts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature would allow adding custom options when calling Conventional Commits Parser. This would allow usage with providers that use different patterns and additional user customization.
Fixes #634, #690
Another possible way to solve this is adding the parserOpts to the .versionrc file. But that would involve changes with the (conventional-changelog-config-spec)[https://github.com/conventional-changelog/conventional-changelog-config-spec]. It might be a cleaner solution at the end.