Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose --skip-unstable flag from conventional-recommended-bump #759

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ferm10n
Copy link

@ferm10n ferm10n commented May 19, 2021

conventional-recommended-bump supports a skipUnstable option which would be very useful for projects that use standard-version and want to make release candidates.

With this feature, standard-version will be able to create changelogs based on official releases only, and exclude previous pre-releases, if desired.

I wanted to have this feature supported so I could:

  • make a v1.0.0
  • make a v2.0.0-beta.0
  • make a v2.0.0
  • see the CHANGELOG for the commits from v1.0.0...v2.0.0, not v1.0.0...v2.0.0-beta.0 + v2.0.0-beta.0...v2.0.0

@ferm10n ferm10n marked this pull request as ready for review May 19, 2021 06:27
@ferm10n ferm10n marked this pull request as draft May 19, 2021 06:36
@ferm10n
Copy link
Author

ferm10n commented May 19, 2021

Just checked it out locally, these changes don't seem to be doing what I expected them to do. The bump recommendation seems to respect the flag, but not the commits included in the changelog

@ferm10n
Copy link
Author

ferm10n commented May 19, 2021

It seems like I might also need to add a skipUnstable option here as well, but when I try that, the changelog output still emits a section for the alpha.

I'm not sure how to approach this yet, I'm still trying to get an idea of how conventional-changelog-core works. Maybe there is a bug in conventional-changelog-core that causes the skipUnstable to not be respected in changelog output.

@ahusemann84
Copy link

I really would like to see this feature working. I am trying to setup a similar process. To achieve a similar behavior already now I use the --skip.tag option when running standard version. This way I get can get changelogs for all stable versions and at least something for the unstable ones. Although this results in a changelog for the unstable version that collects all changes since the last stable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants