Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump conventionalcommits to 4.3.1 #648

Closed
wants to merge 1 commit into from
Closed

fix(deps): bump conventionalcommits to 4.3.1 #648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"chalk": "^2.4.2",
"conventional-changelog": "3.1.21",
"conventional-changelog-config-spec": "2.1.0",
"conventional-changelog-conventionalcommits": "4.3.0",
"conventional-changelog-conventionalcommits": "4.3.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, could these all be changed to ^ or at least ~ versions so that we don't have to wait for conventional-changelog releases to get simple patch fixes in our own repos?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree here, but I didn't want to make this pull request about a practice change, only a dependency update.

Seeing as this is addressed by #650 to a more up-to-date version, I closed this PR. However, I would encourage you to make an issue discussing the suggestion you've made here.

"conventional-recommended-bump": "6.0.9",
"detect-indent": "^6.0.0",
"detect-newline": "^3.1.0",
Expand Down