fix(commit): fix windows by separating add and commit exec #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapppi
changed the title
|
|
||
| function handleExecError (err, stderr) { | ||
| // If exec returns an error or content in stderr, log it and exit with return code 1 | ||
| var errMessage = err || stderr |
There was a problem hiding this comment.
To preserve the old functionality, this should probably be:
var errMessage = stderr || (err && err.message)
|
@Tapppi after you address @nexdrew's comments, seems great 👍 it might also be worth configuring this project for AppVeyor. We can use this config as a basis? |
Windows cmd doesn't support separating commands with ';'. Fix by separating the execution of the 'git add' and 'git commit' commands. Added separate test for git add. Fixes conventional-changelog#49
|
|
happy to land this and address appveyor in another issue.
|
LGTM 👍 Thanks for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows cmd doesn't support separating commands with ';'. Fix by separating
the execution of the 'git add' and 'git commit' commands.
Fixes #49