Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(configuration): Fix typo & required versions #527

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

roschaefer
Copy link
Contributor

@roschaefer roschaefer commented Jan 16, 2020

I've spend at least an hour to figure out why my configuration files were always ignored. After debugging the source of my node_modules/standard-version/* it turns out I had 7.0.1 installed which apparently does not have the feature of bumpFiles or packageFiles.

I don't understand why 7.0.1 and not 7.1.0 got installed. I used yarn add --dev standard-version.

close #504
close #271

I've spend at least an hour to figure out why my configuration files were always ignored. After debugging the source of my `node_modules/standard-version/*` it turns out I had `7.0.1` installed which apparently does not have the feature of `bumpFiles` or `packageFiles`.

I don't understand why `7.0.1` and not `7.1.0` got installed. I used `yarn add --dev standard-version`.

close conventional-changelog#504 conventional-changelog#271
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.429% when pulling 3a9b721 on roschaefer:patch-1 into c934f3a on conventional-changelog:master.

@jbottigliero
Copy link
Member

Hey – thanks for catching this, while the README is expected to match the current release it looks like that's not the case.

At the moment I do not have the proper permissions to publish the npm package... I'll work on getting this sorted out. It looks like the 7.1.0 release was tagged here on GitHub but not published in the registry. It does look like you might be able to use standard-version@next to get the proper version in your lock/package files.

Thanks again for the contribution.

@jbottigliero jbottigliero merged commit 3904075 into conventional-changelog:master Jan 20, 2020
@roschaefer roschaefer deleted the patch-1 branch January 20, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

bumpfiles example uses "file" not "filename" customized path to package.json
3 participants