Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): note about yargs dot notation in lieu of package.json #380

Merged
merged 2 commits into from
Jul 29, 2019

Conversation

godd9170
Copy link
Contributor

@godd9170 godd9170 commented Jun 9, 2019

To help simpletons such as myself understand how yargs work (see #373)

@coveralls
Copy link

coveralls commented Jun 9, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling b3fe463 on Guestlogix:master into c9cb339 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a903742 on Guestlogix:master into e1791ab on conventional-changelog:master.

Copy link
Member

@jbottigliero jbottigliero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@godd9170 do you know if there is official documentation for the dot-notation syntax for yargs?Could we link there instead?

Alternatively, maybe we should alter the Skipping lifecycle steps section to include a CLI example (which I think would cover what you encountered).

@bcoe
Copy link
Member

bcoe commented Jun 11, 2019

@godd9170 my temptation, rather than drawing attention to yargs' docs, which should be an implementation detail, would be to just explain how dot notation works in our documentation.

@godd9170
Copy link
Contributor Author

godd9170 commented Jul 3, 2019

Hey sorry for the delay. How's that wording instead?

@bcoe bcoe merged commit 5c21810 into conventional-changelog:master Jul 29, 2019
@bcoe
Copy link
Member

bcoe commented Jul 29, 2019

@godd9170 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants