Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): .versionrc.js files are now supported #378

Merged
merged 3 commits into from
Aug 24, 2019

Conversation

jbottigliero
Copy link
Member

@jbottigliero jbottigliero commented Jun 8, 2019

  • Updates the configuration retrieval to support Javascript (.js) configurations.
  • Javascript configurations MUST export a configuration object or a function (returning a configuration object) as the default export.
  • Adds details around .versionrc.js to README.

closes #371

@coveralls
Copy link

coveralls commented Jun 8, 2019

Coverage Status

Coverage decreased (-0.1%) to 99.896% when pulling 7705364 on feat-js-configuration-support into fe37e73 on master.

@bcoe
Copy link
Member

bcoe commented Jul 30, 2019

@jbottigliero if you don't mind rebasing, let's land this 👍

Joe Bottigliero added 3 commits August 20, 2019 08:48
- Updates the configuration retrieval to support Javascript (`.js`) configurations.
- Javascript configurations MUST export a configuration object _or_ a function (returning a configuration object) as the default export.

closes #371
@jbottigliero jbottigliero force-pushed the feat-js-configuration-support branch from 8d37968 to 7705364 Compare August 20, 2019 13:50
@jbottigliero jbottigliero merged commit ddc5c00 into master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

.versionrc.json is not being loaded
3 participants